Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

First pass at documenting serializer #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2017
Merged

First pass at documenting serializer #376

merged 1 commit into from
Nov 30, 2017

Conversation

willkg
Copy link
Contributor

@willkg willkg commented Nov 30, 2017

This documents the html5lib.serializer module for issue #307.

@willkg
Copy link
Contributor Author

willkg commented Nov 30, 2017

@gsnedders @jgraham Can one of you review this, please?

@codecov-io
Copy link

Codecov Report

Merging #376 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
- Coverage   90.78%   90.75%   -0.04%     
==========================================
  Files          50       50              
  Lines        6927     6942      +15     
  Branches     1322     1328       +6     
==========================================
+ Hits         6289     6300      +11     
- Misses        482      483       +1     
- Partials      156      159       +3
Impacted Files Coverage Δ
html5lib/serializer.py 85.36% <ø> (ø) ⬆️
html5lib/treebuilders/__init__.py 81.81% <0%> (-18.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d595d0a...f748f3d. Read the comment docs.

@willkg willkg added this to the 1.0 milestone Nov 30, 2017
@willkg
Copy link
Contributor Author

willkg commented Nov 30, 2017

The codecov report is erroneous. The changes are all docstrings--no code changes at all. We can ignore that.

@gsnedders gsnedders merged commit 461bda3 into html5lib:master Nov 30, 2017
@willkg willkg deleted the 307-serializer branch December 4, 2017 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants